Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lerna publish --no-verify option #1366

Closed
hjylewis opened this issue Apr 9, 2018 · 5 comments · Fixed by #1376
Closed

lerna publish --no-verify option #1366

hjylewis opened this issue Apr 9, 2018 · 5 comments · Fixed by #1376

Comments

@hjylewis
Copy link
Contributor

hjylewis commented Apr 9, 2018

Expected Behavior

Running lerna publish publishes to npm and pushes changes to git without going through prepush validation scripts.

Current Behavior

When you run lerna publish and it goes to push the changes using git, it will silently trigger any prepush scripts. In the case where those scripts a while, it looks like lerna is hanging.

Possible Solution

Add a --no-verify flag to lerna publish that pushes to git using the --no-verify flag. That or show the logging of the prepush scripts.

@evocateur
Copy link
Member

We already pass --no-verify directly to git commit, I don't see why we can't do that for git push too (and maybe condense those two calls into one?). It's silly to validate lerna commits and pushes, as it's implied that any validation has been done already.

@hjylewis
Copy link
Contributor Author

hjylewis commented Apr 9, 2018

I agree. If you point me in the right direction, I won't mind making a PR.

@evocateur
Copy link
Member

Yeah, basically those two places I linked, and then modifying relevant unit test assertions. I don't think we really have to go whole-hog and have an integration test with a pre-push hook, we can just assume git knows what its doing.

@hjylewis
Copy link
Contributor Author

hjylewis commented Apr 9, 2018

Whoops, missed your links. Sounds good!

hjylewis added a commit to hjylewis/lerna that referenced this issue Apr 14, 2018
Also, condense the two `git push` calls into one call.

Closes lerna#1366
hjylewis added a commit to hjylewis/lerna that referenced this issue Apr 14, 2018
Also, this condenses the two `git push` calls into one call.

Closes lerna#1366
evocateur pushed a commit that referenced this issue Apr 16, 2018
Also, this condenses the two `git push` calls into one call.

Closes #1366
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants