Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating lock file for individual package #2105

Closed
Designer023 opened this issue May 23, 2019 · 8 comments
Closed

Generating lock file for individual package #2105

Designer023 opened this issue May 23, 2019 · 8 comments
Labels

Comments

@Designer023
Copy link

We have a lerna monorepo which contains our packages and projects that use those packages.

We can deploy just using the package.json file in our project and that works fine (on Netlify), however we'd like to deploy the projects in a way where we know what the packages and dependencies will be when we deploy them - ie. with a lock file.

If we use the root lock file then we're missing the dependencies from the project. If we use the package file in the project then we don't get the benefit of the locked down packages.

If we generate a lock file (package-lock.json) for the project by using lerna exec -- npm install --package-lock then we get the locked files and can deploy fine, however we've had weird issues with dependencies happening that stop it working properly, plus releasing new packages means we need to re run lerna exec -- npm install --package-lock after a bump so the package lock is up to date!

Does anyone have any ideas, workflow suggestions or general tips to help out

Project structure is

packages/internal-package-1
packages/internal-package-2
packages/internal-package-3...
projects/app-1
projects/app-2
lerna.json
package.json
yarn.lock

We build the apps as part of the Netlify deployment. They are Create React Apps. Currently we're running it with the package.json option with no lock file and that works, just with the downside of no locked packages.

@evocateur
Copy link
Member

You're using Yarn, apparently? Confused why you can't use workspaces and avoid awkwardly inserting npm cli-specific metadata files into your workflow.

@ux-engineer
Copy link

@evocateur it seems Lerna 3.14.1 is not creating workspace-specific yarn.lock file, which is especially bad for production build systems / pipelines...

@ux-engineer
Copy link

#1171

@ux-engineer
Copy link

Found this comment – is Yarn Workspaces feature supposed to create project/workspace specific yarn.lock or is there just one created in the root?

https://stackoverflow.com/a/52279466/2442714

@ux-engineer
Copy link

It seems Yarn workspaces indeed is missing that feature: yarnpkg/yarn#5428

@zilijonas
Copy link

In my case, I generated package-lock.json files with npm install command in every separate package.

Then installed synp package and it successfully created yarn.lock from every generated packaged-lock.json:

npm install -g synp
npm install --package-lock-only
synp --source-file package-lock.json

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Hi Folks 👋

You may or may not know that lerna is now under the stewardship of Nrwl (announcement here #3121), a company with a long history of not just producing valuable open-source software (OSS), but also backing others (at the time of writing, Nrwl has donated over $50,000 to OSS it hasn't created, see https://opencollective.com/nx for full details).

Quite simply, Nrwl ❤️ OSS, and is committed to making lerna the best it can be. We use it ourselves.

In order to take this awesome project forward from its current state, it is important that we focus our finite resources on what is most important to lerna users in 2022.

With that in mind, we have identified this issue as being potentially stale due to its age and/or lack of recent activity.


Next steps:

We want to give you some time to read through this comment and take action per one of the steps outlined below, so for the next 14 days we will not make any further updates to this issue.

@Designer023 as the original author of this issue, we are looking to you to update us on the latest state of this as it relates to the latest version of lerna.

Please choose one of the steps below, depending on what type of issue this is:

  • A) If this issue relates to a potential BUG in the latest version of lerna:

  • B) If this issue is a FEATURE request to be added to the latest version of lerna:

    • Simply comment back on this thread so that we know you still want us to consider the request for the latest version of lerna.
  • C) If this issue is a QUESTION which is applicable to latest version of lerna:

  • D) If this issue is no longer applicable to the latest version of lerna:

    • Please close the issue.

If we do not hear from @Designer023 on this thread within the next 14 days, we will automatically close this issue.

If you are another user impacted by this issue but it ends up being closed as part of this process, we still want to hear from you! Please simply head over to our new issue templates and fill out all the requested details on the template which applies to your situation:

https://github.com/lerna/lerna/issues/new/choose

Thank you all for being a part of this awesome community, we could not be more excited to help move things forward from here 🙏 🚀

@github-actions github-actions bot added the stale label Jun 3, 2022
@github-actions
Copy link

Hi Folks 👋

You will have seen in our message above that we at Nrwl are working really hard to bring the lerna repo up to date with what matters most to its community in June 2022.

As previously stated in that message, because we have not heard from the original author of this issue within the last 14 days, we are now automatically closing it.

If any users, including the original author, are still impacted by this issue then we still want to hear from you!

All we ask is that you first update to the latest lerna (5.1.4 at the time of writing) to make sure it is still reproducible, and then fill out one of our new issue templates, providing all the requested details which apply to your situation:

https://github.com/lerna/lerna/issues/new/choose

Many thanks again! 🙏


P.S. Over and above getting to grips with the repo, we have also been hard at work launching a new website, resolving all vulnerabilities, merging exciting new features and reigniting community PR contributions! 🚀

You can read our recent blog post to learn more about what we've been up to:
https://blog.nrwl.io/lerna-5-1-new-website-new-guides-new-lerna-example-repo-distributed-caching-support-and-speed-64d66410bec7

@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants