-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@lerna/legacy-package-management missing dependency on rimraf #3611
Comments
Error and stack trace:
|
Yep, I can confirm. |
Is there a way to get rid of |
i implemented a hot fix. Hopefully this will be reviewed and merged soon. |
@HitkoDev in v7 of lerna (coming next month) it will no longer be installed by default, and folks would have to opt into it. It needs to stick around until the major release because it's a significant breaking change |
Thanks for the PR @tada5hi I'll take a look! |
@JamesHenry I was very happy to do that ✌️ |
I'm pleased to say our e2e tests do actually catch this issue: #3616 It must be that in the workspaces of the folks affected here you are forcing lerna to use rimraf v4 even though it currently depends on v3? |
Nope that's not the case. If you do fresh install of lerna, you'll get $ npm i --verbose lerna@6.6.0
$ cat ./node_modules/rimraf/package.json Edit: changed "6.6.1" to "6.6.0" |
@char0n 6.6.1 was released yesterday after this comment - I upgraded to the latest rimraf as part of the work to fix this issue. The comment applied to 6.6.0 and earlier |
You're right. Sorry, it failed for 6.6.0 - swagger-api/apidom#2650 and I don't have any |
I guess your direct devDependency on it was somehow enough, strange… anyway glad it’s resolved now! |
Current Behavior
Error when running lerna after 6.6.0 release
Expected Behavior
The new @lerna/legacy-package-management module imports from rimraf, so it probably needs to specify rimraf as a dependency to ensure it gets the correct version
The text was updated successfully, but these errors were encountered: