Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): create release when using custom tag-version-separator #3979

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

briananstett
Copy link
Contributor

@briananstett briananstett commented Mar 21, 2024

Description

After the 8.1.0, the version command does not create a GitHub release when using a custom version seperator. This was because the createRelease function had a hard coded @ in tag name filter.

Motivation and Context

Fixes: #3974

How Has This Been Tested?

To test, I create a test repo made changes to a packages and commit them. I then ran:

node /tmp/lerna/dist/packages/lerna/dist/cli.js version --tag-version-separator '-' --conventional-commits --create-release github --yes

And was able to see the new GitHub release created with the appropriate tag

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JamesHenry JamesHenry enabled auto-merge (squash) April 1, 2024 18:38
@JamesHenry JamesHenry merged commit cbe01ba into lerna:main Apr 1, 2024
14 checks passed
@JamesHenry
Copy link
Member

Thank you very much!

@briananstett
Copy link
Contributor Author

@JamesHenry do you know when the next release might be? Looking forward to getting this fix out so I can use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No GitHub release is created when using a 'tag-version-separator' other than '@'
3 participants