fix(version): create release when using custom tag-version-separator

[briananstett]

Description

After the 8.1.0, the version command does not create a GitHub release when using a custom version seperator. This was because the createRelease function had a hard coded @ in tag name filter.

Motivation and Context

Fixes: #3974

How Has This Been Tested?

To test, I create a test repo made changes to a packages and commit them. I then ran:

node /tmp/lerna/dist/packages/lerna/dist/cli.js version --tag-version-separator '-' --conventional-commits --create-release github --yes

And was able to see the new GitHub release created with the appropriate tag

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (change that has absolutely no effect on users)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bbdc78a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 8 targets

• nx run-many --t e2e --parallel=1
• nx run-many -t build --parallel=3
• nx run-many -t test --parallel=3 --ci --maxWorkers=2
• nx run-many -t lint --parallel=3
• nx run integration:integration --ci --maxWorkers=2
• nx-cloud record -- npx nx format:check
• nx prepare-for-e2e e2e-run-task-runner
• nx run-many -t test --parallel=3 --ci --maxWorkers=2 --testTimeout=60000 --testPathIgnorePatterns=save.spec.ts --testPathIgnorePatterns=find-file.spec.ts --testPathIgnorePatterns=chain-class.spec.ts

---

Sent with 💌 from NxCloud.

[JamesHenry]

Thank you very much!

[briananstett]

@JamesHenry do you know when the next release might be? Looking forward to getting this fix out so I can use it.