Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lerna diff without package fails #816

Closed
krainboltgreene opened this issue May 13, 2017 · 2 comments · Fixed by #831
Closed

lerna diff without package fails #816

krainboltgreene opened this issue May 13, 2017 · 2 comments · Fixed by #831
Milestone

Comments

@krainboltgreene
Copy link

Expected Behavior

Diff all packages

Current Behavior

> @unction/all@5.0.2 diff /Users/krainboltgreene/Code/krainboltgreene/unction.js
> lerna diff

/Users/krainboltgreene/Code/krainboltgreene/unction.js/node_modules/.bin/lerna diff <pkg>

Global Options:
  --loglevel                       What level of logs to report.                                                                                      [string] [default: info]
  --concurrency                    How many threads to use if lerna parallelises the tasks.                                                              [number] [default: 4]
  --scope                          Restricts the scope to package names matching the given glob.
                                   (Only for 'run', 'exec', 'clean', 'ls', and 'bootstrap' commands)                                                                  [string]
  --ignore                         Ignore packages with names matching the given glob.
                                   (Only for 'run', 'exec', 'clean', 'ls', and 'bootstrap' commands)                                                                  [string]
  --include-filtered-dependencies  Include all transitive dependencies when running a command, regardless of --scope or --ignore.
  --registry                       Use the specified registry for all npm client operations.                                                                          [string]
  --sort                           Sort packages topologically (all dependencies before dependents)                                                  [boolean] [default: true]
  --max-buffer                     Set max-buffer(bytes) for Command execution                                                                                        [number]
  -h, --help                       Show help                                                                                                                         [boolean]
  -v, --version                    Show version number                                                                                                               [boolean]

Not enough non-option arguments: got 0, need at least 1
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @unction/all@5.0.2 diff: `lerna diff`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @unction/all@5.0.2 diff script 'lerna diff'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the @unction/all package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     lerna diff
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs @unction/all
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls @unction/all
npm ERR! There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/krainboltgreene/.npm/_logs/2017-05-13T23_44_45_696Z-debug.log
lerna.json

{
  "version": "independent",
  "lerna": "2.0.0-rc.4",
  "packages": [
    "source/*"
  ]
}

Your Environment

Executable Version
lerna --version 2.0.0-rc.4
npm --version 4.5.0
node --version v7.7.2
@evocateur evocateur added the bug label May 21, 2017
@evocateur evocateur added this to the v2.0.0 milestone May 21, 2017
@evocateur
Copy link
Member

Definitely a bug, it should be optional ([pkg]), not required (<pkg>). Also found that the progress bar wasn't being disabled properly. Sorry for the delay!

evocateur added a commit to evocateur/lerna that referenced this issue May 21, 2017
evocateur added a commit that referenced this issue May 21, 2017
This also hides the progress bar, which is not needed for diff.

Fixes #816
treshugart pushed a commit to treshugart/lerna that referenced this issue May 24, 2017
This also hides the progress bar, which is not needed for diff.

Fixes lerna#816
@lock
Copy link

lock bot commented Dec 28, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants