Add runScriptSync for use in version lifecycle methods

[cwmoo740]

follow up for #1029 and #774

Makes npm preversion/version/postversion scripts synchronous

Description

Add Package.runScriptSync, NpmUtilities.runScriptInDirSync
Converted Publish.js to use these to run lifecycle scripts at appropriate times

Motivation and Context

The prior pr ran the scripts async, which is slightly confusing when a preversion/version script performs side effects like git add abc.

How Has This Been Tested?

Added tests for all three edited files.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

It would be nice to run all the preversion/version/postversion scripts in parallel instead of sequentially, but still block on them. I thought about doing this but there were significant code changes needed that would add promises everywhere. If that's preferred I can do that too.

[evocateur]

I think we would want to use the concurrent batched async loop for this, rather than sync executions? It's a sticky part of the codebase, to be sure, but matching what the other lifecycle executions do should be sufficient?

[gustaff-weldon]

#1029 (review)

@evocateur I believe in this case the whole point of being able to add eg. custom changelog is to wait for preversion/version/postversion scripts to be done before proceeding with anything else.

[evocateur]

Indeed, I totally spaced that the publish command does not generally worry about parallelism, unlike bootstrap, for example.

[evocateur]

LGTM, thanks for the quick turnaround.

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.