fix: fail when --hoist and --yarn are used together

[marionebl]

Description

• add a plausibility check for cases where typeof options.hoist === 'string' and options.npmClient === 'yarn'
• Fail for this case printing a detailed error message pointing to the yarn + lerna guide

Motivation and Context

• yarn and hoisting produces unexpected results by using npm for nested installs Using yarn and hoisting together causes yarn.lock to be ignored #852
• The solution implemented was proposed via Add warning for using yarn and --hoist together #1053

How Has This Been Tested?

• Added a test case for this in test/BootstrapCommand.js
• Test case performs operation on prepared fixture test/fixtures/BootstrapCommand/yarn-hoist
• No additional effects on rest of code base expected

Types of changes

Debateable, my guess:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[evocateur]

Thanks @marionebl, apologies for the delay!

[edmorley]

Many thanks @marionebl :-)

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.