Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new yarn workspaces config format #1254

Merged
merged 1 commit into from Feb 12, 2018

Conversation

detrohutt
Copy link
Contributor

Description

Use the new workspaces.packages key in package.json when available. Otherwise fall back to current behavior.

Motivation and Context

This allows use of yarn's new nohoist feature

How Has This Been Tested?

My current project has the following relevant versions:

  • node@9.5.0
  • yarn@1.4.1-20180208.2355 (nightly)
  • lerna@2.8.0 (with my patch)

I've only had time to test this manually in my current project. Here's what happened.

  1. I enabled and used the nohoist feature. For more detail on how I did this see my PR to create-react-app

  2. At this point, lerna run start failed with:

EPACKAGES Errored while collecting packages and package graph
TypeError: packageConfigs.some is not a function
  1. I applied this patch. The error went away and everything worked as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evocateur
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants