Add universal hosted git URL support #1278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the separation of concerns between
Package
instances and their consumers by introducing theupdateDependency()
instance method. By judiciously employingnpm-package-arg
and the newPackageGraph
metadata, we no longer have to serialize/deserialize the entire object as an extra step during command preparation.Remaining questions for @gustaff-weldon or @synaptiko:
--git-version-prefix
flag really necessary? Who actually needs to change that sort of thing?--exact
, do we need to keep throwing an error if that option is missing?Breaking Changes
VersionSerializer
andGitVersionParser
have been removedWe now simply recognize any local package name with a matching git url, prefix or not.
npm-package-arg
is pretty handy for this. The documentation still needs updating.Motivation and Context
Having
PublishCommand
mutating internal properties ofPackage
instances by reference always bugged me. Now it's better encapsulated. This will make future refactoring easier.How Has This Been Tested?
Added fixture-based tests of the git-url support added to
lerna publish
in #1033! Also, a few more pieces of #1262 validation.Types of changes
Checklist: