Add cache for checking updated dependencies #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return true; | ||
| } | ||
|
|
||
| return !!find(dependencies, dep => { |
There was a problem hiding this comment.
I think find was previously only getting the first dependency?
There was a problem hiding this comment.
Well it would stop as soon as it found a path where A depended on B. But I guess that doesn't necessarily speed it up because every path is going to be checked anyways.
There has to be a way of representing this data that makes it easy to check every path by simply folding dependencies over. But caching works well enough.
|
👍 |
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#128
Probably not the best but it seems to work on Babel (where the max callstack error happened).
Examples:
babel-types -> all packages updated
babel -> babel only (no other dependencies)
stage-3 preset -> stage-0, stage-1, stage-2, stage-3