Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lerna init should add lerna as a devDependency #131

Merged
merged 1 commit into from
May 16, 2016
Merged

Conversation

hzoo
Copy link
Contributor

@hzoo hzoo commented May 14, 2016

I think we want this as a devDep right? Also do we want to add ^ in front as well?

Also, this means we don't want users to use it as a global npm package?

cc @thejameskyle

@jamiebuilds
Copy link
Contributor

How does ^ interact with x.x.x-beta.x?

And my plan in the future is to make the global CLI use the local version if it exists which would be the preferred way.

@hzoo
Copy link
Contributor Author

hzoo commented May 16, 2016

If you do ^x.x.x-beta it should update all betas and more. http://semver.npmjs.com/

screen shot 2016-05-15 at 9 55 14 pm

It would also get 2.0.1 and 2.1.0 if released

@jamiebuilds
Copy link
Contributor

I don't know about the carrot range because I want the version in lerna.json to always match the version in devDependencies. We can either lock it down to the specific version or open them both up using semver.satisfies. What do you think?

@jamiebuilds
Copy link
Contributor

I'm going to merge this as is for now

@jamiebuilds jamiebuilds merged commit 745624f into master May 16, 2016
@jamiebuilds jamiebuilds deleted the devDep branch May 16, 2016 22:45
@hzoo
Copy link
Contributor Author

hzoo commented May 17, 2016

Ok lets go with locking it down atm then and reevaluate ^ later. Similar to flowconfig although in that case if you don't specify a version it allows any version and otherwise errors if it doesn't match

@lock
Copy link

lock bot commented Dec 28, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants