fix(publish): Ignore non-release tags when detecting from-git

[haraldF]

Filter out tags that are not distribution tags generated by lerna when
running publish --from-git

Description

Our repository has an extra (unrelated) tag, and lerna fails with:

lerna notice cli v3.4.3
lerna info versioning independent
lerna info Verifying npm credentials
lerna http fetch GET 200 https://artifactory.in.here.com/artifactory/api/npm/verity-npm-sandbox/-/whoami 95ms
lerna ERR! TypeError: Cannot destructure property `pkg` of 'undefined' or 'null'.
lerna ERR!     at updates.map (/root/.npm/_npx/55/lib/node_modules/lerna/node_modules/@lerna/publish/index.js:219:43)
lerna ERR!     at Array.map (<anonymous>)
lerna ERR!     at chain.then.updates (/root/.npm/_npx/55/lib/node_modules/lerna/node_modules/@lerna/publish/index.js:219:39)
lerna ERR! lerna Cannot destructure property `pkg` of 'undefined' or 'null'.

reason is that taggedPackageNames contains an undefined value since no package matches the (unrelated) tag.

Motivation and Context

Fixes a crash in lerna

How Has This Been Tested?

Do a lerna version patch, then git tag foo, then try lerna publish from-git => crash.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[evocateur]

This needs a test so we don't regress in the future.

[haraldF]

@evocateur I've added a test.

[evocateur]

Thanks!

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.