feat(publish): Add option --no-git-reset to leave unstaged changes in working tree
#1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for publishes to leave the working tree dirty. Useful if modified package versions need to be persisted for future use (i.e. Docker builds). Relates to #962
evocateur
approved these changes
Nov 23, 2018
| - package-3@1.0.1-alpha.0+SHA | ||
| `); | ||
|
|
||
| const { stdout: statusStdOut } = await gitStatus(); |
There was a problem hiding this comment.
I'm not sure we need an entire helper just to run git status, and in any case, a better snapshot would be tightly focused on just the modified files, which is already used elsewhere:
Suggested change
| const { stdout: statusStdOut } = await gitStatus(); | |
| const modified = await execa.stdout("git", ["ls-files", "--modified"], { cwd }); |
modified in this case is just a newline-separated list of relative file paths, easily snapshotted inline.
evocateur
changed the title
--no-git-reset to leave unstaged changes in working tree
This was referenced Nov 28, 2018
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a flag which allows the user to specify whether or not the working tree should be reset or not. Defaults to true so the tree is always reset.
Motivation and Context
When used in CI (specifically for my staging builds), I want lerna to be able to publish canary versions of my packages which can then be consumed in a subsequent docker build step. Right now, once the package versions are bumped, the working tree is then reset meaning that the docker build of the package which depends on the bumped package, refers to the original package version.
Relates to this comment #962 (comment) in #962.
How Has This Been Tested?
Added a unit test to ensure that when
--no-git-resetis specified,gitCheckoutisn't called.Added an integration test to ensure that when
--no-git-resetis specified, the working tree is left dirty.Types of changes
Checklist:
One test was already failing on my machine:
isAnythingCommitted without and with a commit