Fix checkUpdatedPackages for repos without any tags #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebuilds
changed the title
sebmck
added a commit
that referenced
this pull request
Jan 22, 2016
Fix checkUpdatedPackages for repos without any tags
| @@ -26,8 +26,14 @@ exports.checkUpdatedPackages = function (config) { | |||
|
|
|||
| var tick = progressBar(packageNames.length); | |||
|
|
|||
| var lastTagCommit = execSync("git rev-list --tags --max-count=1"); | |||
| var lastTag = execSync("git describe " + lastTagCommit); | |||
| var hasTags = !!execSync("git tags"); | |||
There was a problem hiding this comment.
Is this supposed to be git tag, since git tags isn't a command I don't think
There was a problem hiding this comment.
➜ lerna git:(master) ✗ git tags
v1.0.1
v1.0.2
v1.0.3
v1.0.4
v1.0.5
v1.1.0
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14