fix(publish) Pass only the project scope to libnpmpublish #1985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parse the
@scope
from the full package name usingnpm-package-arg
and setprojectScope
.The
projectScope
parameter is used bylibnpmpublish
to set theHTTP_NPM_SCOPE
header.Motivation and Context
When publishing scoped packages with Lerna, the
projectScope
used bylibnpmpublish
was being set using the full package name (@scope/name
).This behavior caused some third-party registries to fail when verifying the
HTTP_NPM_SCOPE
header which was expected to match the package@scope
.How Has This Been Tested?
These changes have been tested against the official npm registry and third-party registries to ensure that only the
@scope
parameter will go throughlibnpmpublish
as theprojectScope
.Updated tests in
npm-publish.test
to include@scope
.Types of changes
Checklist:
Related issue
Fixes #1968