Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add lerna changelog #23

Closed
wants to merge 1 commit into from
Closed

WIP: add lerna changelog #23

wants to merge 1 commit into from

Conversation

hzoo
Copy link
Contributor

@hzoo hzoo commented Jan 23, 2016

Fixes #18

So far, I'm just getting a list of commits that are either the merge commit or a commit to master directly.

screen shot 2016-01-23 at 10 09 44 pm

Running:
GITHUB_AUTH=auth-token-here GITHUB_ORG=babel GITHUB_REPO=babel ./node_modules/.bin/lerna changelog

Right now we error if you pass more than 2 args so we'll either have to support multiple args, do more process.env stuff, or add a config file?

@hzoo
Copy link
Contributor Author

hzoo commented Jan 24, 2016

Code sucks but at least it prints out the labels now.

@hzoo
Copy link
Contributor Author

hzoo commented Jan 24, 2016

Almost done but it's needs to be generalized (just want to get it working for babel)

var org = process.env.GITHUB_ORG;
var repo = process.env.GITHUB_REPO;

var tags = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to not hardcode this in

@hzoo hzoo force-pushed the add-changelog branch 3 times, most recently from a32076c to eb6349d Compare January 26, 2016 16:24
@hzoo
Copy link
Contributor Author

hzoo commented Jan 28, 2016

Didn't get to updating the readme but I would do that as well

Maybe a screenshot or example of what it looks like (or just link to the next babel changelog release when we do it).

@hzoo
Copy link
Contributor Author

hzoo commented Jan 28, 2016

Can pr the one in the repo instead of my branch.

@hzoo hzoo closed this Jan 28, 2016
@hzoo hzoo mentioned this pull request Jan 28, 2016
@lock
Copy link

lock bot commented Dec 28, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant