New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bootstrap install to use quotes around versions #235
Conversation
@@ -109,7 +109,7 @@ export default class BootstrapCommand extends Command { | |||
return !this.hasDependencyInstalled(pkg, dependency); | |||
}) | |||
.map(dependency => { | |||
return dependency + "@" + allDependencies[dependency]; | |||
return dependency + "@\"" + allDependencies[dependency] + "\""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting into the range where a template string might be more readable:
return `${dependency}@"${allDependencies[dependency]}"`;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gigabo i concur
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could leave a comment of an example package version of why it needs the quotes
This reverts commit c0f1e8d.
* feature/pkg-main: Bootstrap: copy `main` property from package.json 2.0.0-beta.23 fix execSync use Add `onlyExplicitUpdates` flag so that only packages that have changed have version bumps rather than all packages that depend on the updated packages (lerna#241) Re-introduce node 0.10 support (lerna#248) 2.0.0-beta.22 Consistent naming in README `import` section (lerna#243) [skip ci] Lerna import (lerna#173) Revert "Use sync-exec for node 0.10" (lerna#242) Revert "Fix bootstrap install to use quotes around versions (lerna#235)" 2.0.0-beta.21 Fix bootstrap install to use quotes around versions (lerna#235) typo [skip ci] # Conflicts: # src/commands/BootstrapCommand.js
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #234