fix!: replace npm-lifecycle with @npmcli/run-script #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHenry
force-pushed
the
npm-lifecycle-to-npmcli-run-script
branch
from
9a77c14
to
21babbf
Compare
ghiscoding
added a commit
to lerna-lite/lerna-lite
that referenced
this pull request
May 24, 2022
- fixes #60 by following PR [#3134](lerna/lerna#3134) from original Lerna
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
We are classing this as a breaking change because the APIs of
npm-lifecycleand@npmcli/run-scriptare significantly different, despite@npmcli/run-scriptbeing the official successor tonpm-lifecycle.We have successfully made the integration test suite we inherited pass with this change, but there may potentially be aspects related to it which are not covered by the tests and are breaking. If you encounter any issues you believe are related to this change please open a new issue with a dedicated reproduction for us to look into!