Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init): Create .gitignore with lerna init #3270

Merged
merged 3 commits into from Jul 29, 2022

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jul 29, 2022

Makes the lerna init command now generate a .gitignore file that excludes node_modules/ by default. Existing .gitignore files are untouched.

Motivation and Context

All lerna workspaces will have a node_modules folder that should be excluded from git, so this saves the developer the step of creating the .gitignore file themselves.

How Has This Been Tested?

This has been tested manually, as well as with newly updated unit, integration, and e2e tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review July 29, 2022 04:29
@JamesHenry JamesHenry merged commit 3461348 into lerna:main Jul 29, 2022
@fahslaj fahslaj deleted the gitignore-with-init branch September 2, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants