Indicate private modules in output from updated
#329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 , easy to review |
| @@ -16,7 +16,7 @@ export default class UpdatedCommand extends Command { | |||
|
|
|||
| execute(callback) { | |||
| const formattedUpdates = this.updates | |||
| .map((update) => `- ${update.package.name}`) | |||
| .map((update) => `- ${update.package.name}${update.package.isPrivate()?" (private)":""}`) | |||
There was a problem hiding this comment.
maybe spaces between the operators though
There was a problem hiding this comment.
Oh, yeah. Weird that the linter didn't catch that...
This is helpful for figuring out what will actually be published.
gigabo
force-pushed
the
private-updated
branch
from
46afe4e
to
e9104aa
Compare
This was referenced Sep 10, 2016
rygine
pushed a commit
to awakesecurity/lerna
that referenced
this pull request
Sep 12, 2016
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful for figuring out what will actually be published.
Goes along with #321.
Looks like: