Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add workspace watching feature doc #3487

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jan 5, 2023

Description

Adds a Workspace Watching feature overview with examples to the lerna.js.org website.

Motivation and Context

This helps promote discovery of the new Workspace Watching feature and makes api reference more accessible.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review January 5, 2023 22:35
Copy link
Contributor

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just wanted to add one example. The github UI doesn't like the "```" in the suggestion so you'll have to fix that up in the real commit.

@fahslaj fahslaj merged commit eb4a755 into lerna:main Jan 6, 2023
@fahslaj fahslaj deleted the lerna-watch-recipe branch January 6, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants