Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create): normalize quotes and indents in generated test and lib files #3529

Merged
merged 4 commits into from
Feb 9, 2023
Merged

fix(create): normalize quotes and indents in generated test and lib files #3529

merged 4 commits into from
Feb 9, 2023

Conversation

teddybradford
Copy link
Contributor

re: #3504
This PR normalizes quotes and indents in generated test and lib files to all be single quotes and 2-space indents.

@teddybradford teddybradford changed the title Update formatting changes fix(create): normalize quotes and indents in generated test and lib files Feb 6, 2023
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for recreating this @teddybradford!

Looks like the e2e-publish is failing: https://cloud.nx.app/runs/GghxN3Qy9i

Excuse the verbose logging we currently have enabled, but if you scroll down within e2e-publish you will see the relevant snapshot failures

@teddybradford
Copy link
Contributor Author

@JamesHenry I'm not very familiar with this repo. It looks like this error is occurring: > NX ERROR: Something went wrong in run-commands - Command failed: E2E_ROOT=$(npx ts-node tools/scripts/set-e2e-root.ts) nx run-e2e-tests e2e-publish. Any idea why my changes would cause this to fail?

@JamesHenry
Copy link
Member

Yes it's the jest snapshots:

image

We have very verbose debugging logging enabled for ourselves at the moment so I'm afraid it is a little buried in there.

To resolve it I ran the relevant e2e tests and passed -u to instruct it to update the snapshots.

npx nx e2e e2e-publish -u

To save you time I have gone ahead and committed the result already, let's see if there is anything else outstanding on CI now (my local machine was playing up a bit so it's possible I missed an update or too as well)

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @teddybradford!

@JamesHenry JamesHenry merged commit ad39fe2 into lerna:main Feb 9, 2023
@teddybradford
Copy link
Contributor Author

@JamesHenry Awesome! Thanks, James.

@teddybradford teddybradford deleted the patch-1 branch February 9, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants