Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): reactivate unit tests previously failing on windows os platform #3626

Merged
merged 4 commits into from Mar 31, 2023

Conversation

amorscher
Copy link
Contributor

Reactivates unit test which failed in the past

Description

Reactivates unit test which failed in the past

Motivation and Context

Re-activate ignored unit tests to achieve higher test coverage and regression testing.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nx-cloud
Copy link

nx-cloud bot commented Mar 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eaf3f5e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@amorscher amorscher changed the title chore(test): reactivate unit tests# chore(test): reactivate unit tests previously failing on windows os platform Mar 29, 2023
 - just re-activate tests as they completed successfully
@amorscher
Copy link
Contributor Author

Hmmm just got feedback from the ci runs... I reinstalled the import-command-spec filter as it seems to fail during ci run although it passes locally...

@amorscher
Copy link
Contributor Author

Import command test will be handled in own pull request #3629

@fahslaj
Copy link
Contributor

fahslaj commented Mar 31, 2023

Looks like this PR has conflicts, but once those are resolved, we can merge it if it is still relevant and these changes aren't in one of the other prs

@fahslaj fahslaj merged commit 71a4cdd into lerna:main Mar 31, 2023
14 checks passed
@fahslaj
Copy link
Contributor

fahslaj commented Mar 31, 2023

Thanks @amorscher !

@amorscher amorscher deleted the reactivate-unit-tests branch September 23, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants