-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add name of package that fails to publish #3644
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 687245a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 8 targets
Sent with 💌 from NxCloud. |
67d9132
to
c894e1d
Compare
Hi @Nokel81 , thank you for opening this PR. It looks like this is failing the format checking in CI. Can you please run |
c894e1d
to
58cf4de
Compare
@fahslaj Done |
@Nokel81 It looks like the latest change broke the new unit test in the PR |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
e7e516e
to
687245a
Compare
@fahslaj I fixed the failing unit test that I added |
Looks good. Thanks @Nokel81 ! |
Description
Add a warning log entry when
lerna publish
fails that includes the package name.Motivation and Context
Sometimes there error returned from the registry doesn't include the package name. For instance
ERR! E402 You must sign up for private packages
.How Has This Been Tested?
Types of changes
Checklist: