Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add name of package that fails to publish #3644

Merged
merged 4 commits into from
May 9, 2023

Conversation

Nokel81
Copy link
Contributor

@Nokel81 Nokel81 commented Apr 12, 2023

Description

Add a warning log entry when lerna publish fails that includes the package name.

Motivation and Context

Sometimes there error returned from the registry doesn't include the package name. For instance ERR! E402 You must sign up for private packages.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nx-cloud
Copy link

nx-cloud bot commented Apr 12, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 687245a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@fahslaj fahslaj force-pushed the add-package-name-failure-publish branch from 67d9132 to c894e1d Compare May 3, 2023 20:07
@fahslaj
Copy link
Contributor

fahslaj commented May 4, 2023

Hi @Nokel81 , thank you for opening this PR. It looks like this is failing the format checking in CI. Can you please run npx nx format:check locally and ensure everything is correct?

@Nokel81 Nokel81 force-pushed the add-package-name-failure-publish branch from c894e1d to 58cf4de Compare May 5, 2023 13:49
@Nokel81
Copy link
Contributor Author

Nokel81 commented May 5, 2023

@fahslaj Done

@fahslaj
Copy link
Contributor

fahslaj commented May 8, 2023

@Nokel81 It looks like the latest change broke the new unit test in the PR

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 force-pushed the add-package-name-failure-publish branch from e7e516e to 687245a Compare May 9, 2023 18:37
@Nokel81
Copy link
Contributor Author

Nokel81 commented May 9, 2023

@fahslaj I fixed the failing unit test that I added

@fahslaj fahslaj merged commit 11d8473 into lerna:main May 9, 2023
13 checks passed
@fahslaj
Copy link
Contributor

fahslaj commented May 9, 2023

Looks good. Thanks @Nokel81 !

@Nokel81 Nokel81 deleted the add-package-name-failure-publish branch May 9, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants