feat(core): convert commands to use nx project graph instead of package graph #3667
Conversation
chore: move legacy package graph functions chore: extract project operations into individual files chore(core): move legacy features to @lerna/legacy-core chore: bump nx version to 15.8.8 chore: add lodash types chore: use resetDaemonClient argument when creating project graph
fahslaj
force-pushed
the
feature/nx-project-graph
branch
from
27ff6ee
to
ef5c15a
Compare
|
|
||
| it("lists packages under explicitly configured node_modules directories", async () => { |
There was a problem hiding this comment.
This test and the one below represent functionality that is no longer supported, which is the explicit configuration of including node_modules within the package config globs.
Nx does not support projects within the node_modules directory.
| @@ -220,28 +221,6 @@ Map { | |||
| ]); | |||
| }); | |||
|
|
|||
| it("produces a topological ordering that _excludes_ devDependencies when value is 'dependencies' (DEPRECATED)", async () => { | |||
There was a problem hiding this comment.
This is removed functionality.
The publish command will always function as if this option is set to "--all", as that is what topological traversing of the Nx project graph will get us by default.
There was a problem hiding this comment.
This file has the test cases from legacy-core/src/lib/collect-updates/index.spec.ts ported to work with the new projects-based api.
There was a problem hiding this comment.
This function combines the functionality of the old getFilteredPackages and filterPackages helpers into one function, adapting it to the new projects-based api.
There was a problem hiding this comment.
Test and function were moved up a directory.
There was a problem hiding this comment.
This replaces listable-format.ts
| @@ -252,6 +258,30 @@ export class Package { | |||
| return writePkg(this.manifestLocation, this[PKG] as any).then(() => this); | |||
| } | |||
|
|
|||
| getLocalDependency( | |||
There was a problem hiding this comment.
Lerna does not recognize peerDependencies
There was a problem hiding this comment.
This, along with toposort-projects, replace the QueryGraph & PackageGraph structure for the purposes of topological operations.
There were not unit tests for this functionality beforehand. The test cases added are based on observed behavior of the previous version of Lerna, with the exception of the overlapping cycles case. In this case, the output is slightly different than the previous Lerna, but it is still a valid topological ordering.
There was a problem hiding this comment.
Test cases created by observing Lerna's existing behavior.
| // reset lerna.json and package-lock.json after publish of a local version | ||
| if (options.local) { | ||
| execSync("git checkout -- lerna.json package-lock.json"); | ||
| } | ||
| } else { | ||
| // JH: remove unneeded await | ||
| version(versionOptions); |
There was a problem hiding this comment.
This --dryRun case will still need to be reviewed. I suspect that it will still create a git commit for the version operation.
There was a problem hiding this comment.
This and get-unpublished-packages below are no longer exported from Lerna. If absolutely needed, we can add back and export the old version of the function that uses the package graph.
| @@ -146,28 +145,6 @@ lerna publish from-package --git-head ${CODEBUILD_RESOLVED_SOURCE_VERSION} | |||
|
|
|||
| Under all other circumstances, this value is derived from a local `git` command. | |||
|
|
|||
| ### `--graph-type <all|dependencies>` | |||
There was a problem hiding this comment.
--graph-type is no longer supported. This was called out as deprecated in the code, giving a warning when used that it would be removed in Lerna v6.
The Nx project graph doesn't distinguish between dependencies or dev dependencies, so it naturally doesn't implement this flag's behavior. I figured since it was deprecated, it should be removed instead of implemented over the Nx project graph.
No description provided.