[Feature] Log stdout when commands fail. Fixes #343. #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2016 13:22
The decorator spec requires that a function decorator either: - returns a new /descriptor/ for the property, or - changes the fields on the given descriptor The logify* methods instead returned a new function implementation, which is not correct, and caused the decorations to be silently ignored. decorator spec: https://github.com/wycats/javascript-decorators#detailed-design function decorator example: https://github.com/jayphelps/core-decorators.js/blob/master/src/deprecate.js This commit changes logifySync and logifyAsync in the following ways: - they now have no return value, and instead modify the descriptor - they now must be called with no arguments so they can properly capture the `this` value (without this, the function cannot find the logger instance) - they now log at 'verbose', because they are extremely verbose - remove 'error' flag from non-error logging - they truncate their serialized arguments to (arbitrarily) 100 characters because otherwise they they OOM the node process Additionally, one async method was erroneously decorated with logifySync.
ChildProcessUtilities now returns stdout as the second argument of a callback. logifyAsync will check for the presence of a second argument and log it out in the case of an error, too.
This was referenced Oct 17, 2016
|
Should we be combining |
jamiebuilds
changed the title
|
I hadn't thought of that, but yeah, I think that's the right thing to do. Will take another look Thursday. |
|
@thejameskyle finally got around to making those changes. |
doug-wade
approved these changes
Jan 28, 2017
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChildProcessUtilities now returns stdout as the second argument of
a callback. logifyAsync will check for the presence of a second
argument and log it out in the case of an error, too.