Enable throttling when publishing modules

[Ayowel]

The aim is to provide a way to fix #3962 .

This is opened to validate the implementation design and get feedback on the specific values that should be used as defaults.

Currently known limits when uploading to NPM:

• Burst limit of 25/500 modules per 24h (depending on account/already-published modules)

Description

Add three publishing options:

• --throttle to enable/disable throttling
• --throttle-size: the 'bucket size' to use when throttling
• --throttle-delay: Once the bucket is full, the minimum time between the end of a module upload and the start of an other module's upload

Throttling is enabled by default when publishing to NPM. The throttling implementation is designed to allow changes in the implementation/maintaining different implementations without too much trouble

Motivation and Context

See #3962: NPM throttles module publishing, which results in partial publish which are a pain to deal with

How Has This Been Tested?

Tested on ubuntu with node 20.9.0:

• With the new testfile libs/commands/publish/src/lib/throttle-queue.spec.ts
• By publishing to a local verdaccio instance

The removal from draft of this PR will wait for the upload to NPM of a 10000+ modules monorepo

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[JamesHenry]

@Ayowel this comment wasn't entirely clear to me:

The removal from draft of this PR will wait for the upload to NPM of a 10000+ modules monorepo

Are you going to be reporting back to us once you have done this? Is that repo in question a real thing? Or something built just to test this functionality?

I have pulled in the latest main so that you can get initial CI feedback

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 376dcc0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 8 targets

• nx prepare-for-e2e e2e-run-task-runner
• nx run-many --t e2e --parallel=1
• nx run-many -t test --parallel=3 --ci --maxWorkers=2
• nx run-many -t lint --parallel=3
• nx run-many -t build --parallel=3
• nx run integration:integration --ci --maxWorkers=2
• nx-cloud record -- npx nx format:check
• nx run-many -t test --parallel=3 --ci --maxWorkers=2 --testTimeout=60000 --testPathIgnorePatterns=save.spec.ts --testPathIgnorePatterns=find-file.spec.ts --testPathIgnorePatterns=chain-class.spec.ts

---

Sent with 💌 from NxCloud.

[JamesHenry]

It failed code formatting, you can run npm run format:write and commit the result

[Ayowel]

Are you going to be reporting back to us once you have done this? Is that repo in question a real thing? Or something built just to test this functionality?

The repo is a real thing, I'm having trouble with the specifics of lerna's configuration as some configuration works when testing locally on a small repo but not when pushing with the actual repository.

It appears that the NPM limit is not fixed (I was at 25 publish per day before getting timed-out initially, I'm allowed ~500/day at the moment and I'm not clear why the limit changed), so I'll move throttling to an off-by-default state to honor the principle of least astonishment (and enabling throttling will be the user's responsibility).

I'll rebase, format, and push once I figure this out

[Ayowel]

@JamesHenry Looks good to me, removing draft status.
To whom it may interest, the throttling configuration I'm using at the moment to publish to NPM is the following (keep in mind that my current limit is 500/day, not the 25 that an account that has not published module might have):

{
  "command": {
    "publish": {
      "throttle": true,
      "throttleDelay": 7200,
      "throttleSize": 40
    }
  }
}

[Ayowel]

Not sure if I should keep rebasing each time master is updated, let me know if i shouldn't