Make bootstrap, exec and run commands execute packages in dependency order by default #412

seansfkelley · 2016-11-21T03:11:57Z

No description provided.

seansfkelley · 2016-12-01T19:00:00Z

Permissions errors on the AppVeyor build per usual. 😞

seansfkelley · 2016-12-01T19:02:22Z

This probably clashes awkwardly with #386; I would prefer that one get merged first and then I'll update this as appropriate.

sbryfcz · 2016-12-13T14:46:49Z

Just wanted to say that I'd love #412 to get merged. Very typical in the micro-repos that I create to have a number of small packages and one that bundles them all into a single place. Would love to be able to run my build scripts and then perform a publish. But as you know, lerna run doesn't preserve the toposort order so things get built out of proper sequence. Thanks for all the hard work! Love this library.

gigabo · 2016-12-13T19:26:37Z

@seansfkelley #386 has merged. Please rebase this when you get a chance.

Conflicts: src/commands/BootstrapCommand.js src/commands/ExecCommand.js src/commands/RunCommand.js test/PackageUtilities.js

seansfkelley · 2016-12-17T22:12:00Z

@gigabo updated!

seansfkelley · 2016-12-17T22:17:36Z

src/commands/BootstrapCommand.js

    this.logger.info(`Bootstrapping ${this.filteredPackages.length} packages`);
+    this.batchedPackages = this.flags.toposort


Open question: bootstrap used to toposort by default. For consistency, I have tentatively made toposort opt-in-only across the board. Is this behavioral change (1) a good idea? and (2) sufficiently breaking for a beta version to justify special-casing bootstrap?

I am tempted to say (1) yes and (2) no, assuming there is a way we can call out to existing beta users that the default behavior has changed (maybe add a log line in bootstrap if the option was not specified?).

Oh, boy. Yeah, I appreciate that making it opt-in for bootstrap is consistent.

I guess a repo that does need it can just add it to lerna.json.

So are there any changes I should make here, or is it good to go?

Ping @gigabo: thoughts?

@seansfkelley I think it is more important to be right than it is to be fast, since it is much slower to get a build failure and have to debug and rebuild toposorted than it is to waste the excess time running toposorted when you don't strictly need it, but that we should strive to "do the right thing" as often as possible. I would actually propose two flags, --sorted and --unsorted (I don't think the topo prefix helps much) that overrides the default behavior, and then set a reasonable default per-command (that is to say, run run, exec and bootstrap sorted and the rest unsorted). By making any command where sorting might be required sorted, we save less experienced users from erroring/rebuilding as often as possible; by providing flags to override the default behavior of any command, we allow more savvy users to use lerna in ways we haven't anticipated yet to do clever new things.

The most foolproof correct way to implement this flag would then be to default it on always, and provide a --no-sort option to disable it, no? (Agree that "topo" is probably noisy; I think "no sort" is phrased the most CLI-like though.)

@seansfkelley That sounds great.

Thanks for the suggestion @doug-wade.

xaka · 2017-01-19T19:14:50Z

Is there anything that's blocking this PR? It's becoming important for our team as we're adding more and more packages to monorepo, and doing fresh bootstrap isn't option anymore. The problem is when you have packages A and B (depends on A), and you introduce new package C being used by first two, you have to manually toposort everything in your head and do scoped bootstrap to save time.

gigabo · 2017-01-19T19:18:17Z

@xaka I think @seansfkelley was planning to make some tweaks before we merge.

seansfkelley · 2017-01-24T01:31:34Z

@gigabo it should be good to go now.

gigabo · 2017-01-24T01:36:28Z

Awesome! Thanks @seansfkelley!

gigabo · 2017-01-24T01:51:45Z

@seansfkelley I updated the title to try to reflect the current state of what this provides. Please improve it if you've got better wording. It will go into the changelog entry for this PR.

seansfkelley · 2017-01-24T02:24:48Z

Okay, changed (a bit wordier but more precise).

sbryfcz · 2017-01-24T13:29:08Z

Awesome work! Looking forward to the merge.

xaka · 2017-01-25T20:11:50Z

Would be nice to have another pre-release version with this change in 🎆 It's big and important one.

doug-wade

Hi @seansfkelley I'm super excited to get this in. Would you mind rebasing it (hopefully one last time) and we'll get it merged?

seansfkelley · 2017-01-29T00:07:26Z

@doug-wade done!

lock · 2018-12-27T20:21:10Z

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Add --toposort option. Fixes #342.

7b49add

seansfkelley mentioned this pull request Dec 7, 2016

[Discussion] Lerna Maintenance #408

Closed

gigabo added the enhancement label Dec 13, 2016

gigabo mentioned this pull request Dec 15, 2016

feature request: update dependencies #448

Closed

seansfkelley mentioned this pull request Dec 16, 2016

[Feature] Adds --include-filtered-dependencies flag for bootstrap command #390

Merged

Sean Kelley added 3 commits December 17, 2016 13:32

Merge remote-tracking branch 'upstream/master' into toposort

db7242d

Conflicts: src/commands/BootstrapCommand.js src/commands/ExecCommand.js src/commands/RunCommand.js test/PackageUtilities.js

Fix async PackageUtilities test to actually wait for completion.

ea4ba73

Fix imports for RunCommand and ExecCommand.

c945723

seansfkelley commented Dec 17, 2016

View reviewed changes

seansfkelley mentioned this pull request Dec 17, 2016

Add link command. Fixes #341. #452

Closed

seansfkelley mentioned this pull request Jan 12, 2017

[Bug] lerna publish: topologically sort packages #492

Closed

--toposort -> --no-sort; change semantics as appropriate.

1b2a5ee

gigabo mentioned this pull request Jan 23, 2017

Lerna should publish in dependency order #526

Closed

seansfkelley added 2 commits January 23, 2017 17:29

Merge branch 'master' into toposort

de84860

Fix Bootstrap early-exit condition.

4d1817f

gigabo approved these changes Jan 24, 2017

View reviewed changes

gigabo changed the title ~~Add --toposort option. Fixes #342.~~ Run more tasks in dependency graph order Jan 24, 2017

seansfkelley changed the title ~~Run more tasks in dependency graph order~~ Make bootstrap, exec and run execute packages in dependency order by default Jan 24, 2017

seansfkelley changed the title ~~Make bootstrap, exec and run execute packages in dependency order by default~~ Make bootstrap, exec and run commands execute packages in dependency order by default Jan 24, 2017

doug-wade approved these changes Jan 28, 2017

View reviewed changes

Merge branch 'master' into toposort

e62482c

doug-wade merged commit de4ee58 into lerna:master Jan 29, 2017

seansfkelley deleted the toposort branch January 30, 2017 23:52

loganfsmyth mentioned this pull request Feb 10, 2017

Publish npm packages in topological order. #595

Merged

lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make bootstrap, exec and run commands execute packages in dependency order by default #412

Make bootstrap, exec and run commands execute packages in dependency order by default #412

seansfkelley commented Nov 21, 2016

seansfkelley commented Dec 1, 2016

seansfkelley commented Dec 1, 2016

sbryfcz commented Dec 13, 2016

gigabo commented Dec 13, 2016

seansfkelley commented Dec 17, 2016

seansfkelley Dec 17, 2016

gigabo Dec 19, 2016

seansfkelley Dec 22, 2016

seansfkelley Jan 5, 2017

doug-wade Jan 6, 2017

seansfkelley Jan 6, 2017

gigabo Jan 6, 2017

xaka commented Jan 19, 2017

gigabo commented Jan 19, 2017

seansfkelley commented Jan 24, 2017

gigabo commented Jan 24, 2017

gigabo commented Jan 24, 2017 •

edited

Loading

seansfkelley commented Jan 24, 2017

sbryfcz commented Jan 24, 2017

xaka commented Jan 25, 2017

doug-wade left a comment

seansfkelley commented Jan 29, 2017

lock bot commented Dec 27, 2018

		this.logger.info(`Bootstrapping ${this.filteredPackages.length} packages`);
		this.batchedPackages = this.flags.toposort

Make bootstrap, exec and run commands execute packages in dependency order by default #412

Make bootstrap, exec and run commands execute packages in dependency order by default #412

Conversation

seansfkelley commented Nov 21, 2016

seansfkelley commented Dec 1, 2016

seansfkelley commented Dec 1, 2016

sbryfcz commented Dec 13, 2016

gigabo commented Dec 13, 2016

seansfkelley commented Dec 17, 2016

seansfkelley Dec 17, 2016

Choose a reason for hiding this comment

gigabo Dec 19, 2016

Choose a reason for hiding this comment

seansfkelley Dec 22, 2016

Choose a reason for hiding this comment

seansfkelley Jan 5, 2017

Choose a reason for hiding this comment

doug-wade Jan 6, 2017

Choose a reason for hiding this comment

seansfkelley Jan 6, 2017

Choose a reason for hiding this comment

gigabo Jan 6, 2017

Choose a reason for hiding this comment

xaka commented Jan 19, 2017

gigabo commented Jan 19, 2017

seansfkelley commented Jan 24, 2017

gigabo commented Jan 24, 2017

gigabo commented Jan 24, 2017 • edited Loading

seansfkelley commented Jan 24, 2017

sbryfcz commented Jan 24, 2017

xaka commented Jan 25, 2017

doug-wade left a comment

Choose a reason for hiding this comment

seansfkelley commented Jan 29, 2017

lock bot commented Dec 27, 2018

gigabo commented Jan 24, 2017 •

edited

Loading