Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lerna diff command #45

Merged
merged 4 commits into from Feb 20, 2016
Merged

Add lerna diff command #45

merged 4 commits into from Feb 20, 2016

Conversation

jamiebuilds
Copy link
Contributor

Resolves #41

@jamiebuilds jamiebuilds mentioned this pull request Feb 11, 2016
@hzoo
Copy link
Contributor

hzoo commented Feb 11, 2016

Do we need to add an entry to meow? Also update the readme with usage

filePath += "/" + packageName;
}

var diff = child.spawn("git", ["diff", "--color", filePath]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kittens/lerna/blob/master/lib/utils/checkUpdatedPackages.js#L25

Do we want to check against the last tag? lastTag = execSync("git describe --tags " + lastTagCommit);

Or is that another cli parameter to pass in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to check against the last tag?

Oh right duh.

Or is that another cli parameter to pass in?

I think this should just be a simple command to see everything since the last release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I saw in the OP you said last tag too. Yeah for sure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go in after you add the last tag stuff (I pasted it from another command, and you can make it a util if you want), or I can finish it up

jamiebuilds added a commit that referenced this pull request Feb 20, 2016
Add lerna diff command
@jamiebuilds jamiebuilds merged commit 91a22ec into master Feb 20, 2016
@jamiebuilds jamiebuilds deleted the diff branch February 20, 2016 20:39
@lock
Copy link

lock bot commented Dec 28, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants