Add --message option for custom commit msgs when publishing #460
Conversation
| @@ -310,13 +310,8 @@ export default class PublishCommand extends Command { | |||
| } | |||
|
|
|||
| gitCommitAndTagVersionForUpdates() { | |||
| let message = "Publish" + EOL; | |||
There was a problem hiding this comment.
Shouldn't we only change the message part? The tags part should stay the same.
# commit message now
Publish
- package-1@1.0.1
- package-2@1.1.1
# commit message with custom message
chore: release :rocket:
- package-1@1.0.1
- package-2@1.1.1
There was a problem hiding this comment.
Afaict, this change doesn't actually seem to change the tag name, only the commit message. It's just that previously, tags was part of the commit message, so @traviskaufman changed how the tags is computed, but with the same output.
|
This looks ready to merge to me 👍 |
|
As @doug-wade mention this patch should only change the commit message, leaving the tags alone. I believe this is verified since the tests I wrote for this use the same tag names as other tests and pass. If there's anything else that needs to be done let me know. Otherwise, it would be great if we could merge this soon! Our codebase is in need of it :) |
|
Friendly ping! 😄 |
|
🔔 😄 |
1 similar comment
|
🔔 😄 |
This commit introduces a new option for publish: --message. When given this option, lerna will use the supplied message as the commit message when it commits updates while publishing. If no message flag is specified, the default hard-coded messages are used. Resolves lerna#395
traviskaufman
force-pushed
the
feat/custom-publish-commit-msg
branch
from
a69e782
to
7b19f18
Compare
|
Merge conflicts fixed. Thanks for the review! |
|
Good stuff @traviskaufman! |
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This commit introduces a new option for publish: --message. When given
this option, lerna will use the supplied message as the commit message
when it commits updates while publishing. If no message flag is
specified, the default hard-coded messages are used.
Resolves #395