Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade inquirer dependency #541

Merged
merged 2 commits into from
Jan 28, 2017
Merged

Upgrade inquirer dependency #541

merged 2 commits into from
Jan 28, 2017

Conversation

wtgtybhertgeghgtwtg
Copy link
Contributor

Reduces dependencies by one.
I didn't see it specified in engines, but since Travis only runs on node>=4, I figured node@0.12.0 support was dropped. If that's wrong, I'll close this.

@gigabo
Copy link
Contributor

gigabo commented Jan 28, 2017

Thanks @wtgtybhertgeghgtwtg. IIRC the interface for inquirer changed between these two versions. We may need to update our usage.

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

I think you're right, they moved from callbacks to promises. I'll update that in PromptUtilities.

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

It should be fixed. However, PromptUtilities can't be tested.

Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evocateur
Copy link
Member

Parenthetically: I looked into inquirer's tests, and they're solid (and complicated, yikes). We do enough validation of internal PromptUtilities usage that I'm confident these changes are safe.

@evocateur evocateur changed the title Bump inquirer. Upgrade inquirer dependency Jan 28, 2017
@evocateur evocateur merged commit 83e6ab1 into lerna:master Jan 28, 2017
@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg deleted the bump-inquirer branch January 28, 2017 22:57
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants