Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue: prepublish not running in dependencies with --scope --include-filtered-dependencies #542

Merged
merged 2 commits into from
Jan 28, 2017

Conversation

roblg
Copy link
Contributor

@roblg roblg commented Jan 28, 2017

This fixes an issue where lerna bootstrap --scope foo --include-filtered-dependencies
was only running prepublish in the specifically-named scoped packages, rather than in
all transitive dependencies. (e.g., foo gets prepublish run, but if foo depends on bar, bar doesn't get prepublished).

I think this was maybe just missed in #390?

This fixes an issue where `--scope foo --include-filtered-dependencies`
was only running `prepublish` in the scoped packages, rather than in
all transitive dependencies.
Copy link
Contributor

@doug-wade doug-wade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding to the tests @roblg

@hzoo hzoo added the bug label Jan 28, 2017
@hzoo hzoo merged commit 5b8349e into lerna:master Jan 28, 2017
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants