Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage report #575

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Add coverage report #575

merged 1 commit into from
Feb 4, 2017

Conversation

doug-wade
Copy link
Contributor

In response to #574 (comment)

@gigabo
Copy link
Contributor

gigabo commented Feb 3, 2017

Whoa, speedy @doug-wade is speedy. 🚀

@gigabo
Copy link
Contributor

gigabo commented Feb 3, 2017

What would we have to do to get a GitHub integration for this and see it in PRs?

@doug-wade
Copy link
Contributor Author

I use codecov for that, which adds a summary to pull requests, but not a full coverage report. I can set that up over the weekend if that's what we want. The other provider I've used in coveralls, but codecov is newer and newer is always better 😉.

@hzoo
Copy link
Contributor

hzoo commented Feb 3, 2017

Babel uses codecov babel/babel@db67d7f also does es6 coverage

Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@doug-wade doug-wade merged commit 0516be7 into lerna:master Feb 4, 2017
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants