Install with no arguments #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use temporary package.json files. This is groundwork for: - Pluggable npm clients (yarn). - A `lerna upgrade` command. This is a port of asini/asini#45.
evocateur
approved these changes
Feb 3, 2017
doug-wade
reviewed
Feb 3, 2017
| // Return a tuple like ["foo", "^1.0.0"]. | ||
| // Handles scoped packages. | ||
| // Returns undefined for version if none specified. | ||
| static splitVersion(dep) { |
There was a problem hiding this comment.
I share @rygine's enthusiasm for regexes, but it seems that you could write tests for splitVersion directly that verified that it works as intended, which would make me feel much better.
There was a problem hiding this comment.
Good call. Added some tests.
| @@ -39,6 +39,16 @@ export default class FileSystemUtilities { | |||
| fs.writeFile(filePath, ensureEndsWithNewLine(fileContents), callback); | |||
| } | |||
|
|
|||
| @logger.logifyAsync() | |||
There was a problem hiding this comment.
It seems like most FileSystemUtilities have tests; seems worthwhile to add some for these as well.
There was a problem hiding this comment.
Another good call. Added some more tests.
doug-wade
approved these changes
Feb 4, 2017
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use temporary package.json files.
This is groundwork for:
lerna upgradecommand.This is a port of asini/asini#45. Please see original PR commentary during review.