Improve support for --include-filtered-dependencies #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support to `ls`,`exec`,`run` * Removes need for additional instance variable on BootstrapCommand, CleanCommand * Adds tests for ls, exec, run
|
Add a Liking this so far! |
evocateur
approved these changes
Feb 7, 2017
|
(Oddly enough, ignoring whitespace made the additions in the ExecCommand test to disappear, so it's not rocket surgery...) |
hzoo
reviewed
Feb 8, 2017
| callback(); | ||
| }); | ||
|
|
||
| describe.only("with --include-filtered-dependencies", () => { |
There was a problem hiding this comment.
I guess we need to lint for this?
There was a problem hiding this comment.
Ugh. I swear I checked for this this time :(
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ls,exec,runThis PR looks huge because I had to change whitespace in a couple of tests, and added new fixtures, but the "actual" work is mostly in
Command.js, with some find-and-replace inBootstrapCommand.js, andCleanCommand.js.