Explicit registry flag feature #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evocateur
suggested changes
Feb 11, 2017
src/commands/PublishCommand.js
Outdated
| @@ -338,14 +338,15 @@ export default class PublishCommand extends Command { | |||
| }); | |||
|
|
|||
| this.progressBar.init(this.packagesToPublish.length); | |||
| this.npmRegistry = this.getOptions().registry; | |||
There was a problem hiding this comment.
This should be done once, in the initialize method.
There was a problem hiding this comment.
Moved to runPreparations() so every command has access to it. I hope it does not count as an overkill :)
|
Sounds good!
… On Feb 11, 2017, at 11:27, Norbert Csaba Herczeg ***@***.***> wrote:
@noherczeg commented on this pull request.
In src/commands/PublishCommand.js:
> @@ -338,14 +338,15 @@ export default class PublishCommand extends Command {
});
this.progressBar.init(this.packagesToPublish.length);
+ this.npmRegistry = this.getOptions().registry;
Moved to runPreparations() so every command has access to it. I hope it does not count as an overkill :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
evocateur
approved these changes
Feb 14, 2017
|
Once @doug-wade has a chance to review this, we'll be good to go. |
|
Thanks @evocateur ! :) |
|
Looks like the master build failed after this landed.
|
|
ugh. must have collided. I'll hop on it. |
Merged
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected version of #563
Again, sorry for messing up the previous PR.