add tests for NpmUtilities.getExecOpts()

src/NpmUtilities.js

@@ -17,16 +17,8 @@ export default class NpmUtilities {
 
     const args = ["install"];
 
-    const opts = {
-      cwd: directory,
-      stdio: ["ignore", "pipe", "pipe"],
-    };
-
-    if (registry) {
-      opts.env = Object.assign({}, process.env, {
-        npm_config_registry: registry,
-      });
-    }
+    const opts = NpmUtilities.getExecOpts(directory, registry);
+    opts.stdio = ["ignore", "pipe", "pipe"];
 
     const packageJson = path.join(directory, "package.json");
     const packageJsonBkp = packageJson + ".lerna_backup";

test/BootstrapCommand.js

@@ -784,12 +784,11 @@ describe("BootstrapCommand", () => {
       // mock out the ENV to a simpler version for testing
       process.env = mockEnv;
 
+      const bootstrapCommand = new BootstrapCommand([], {});
       const env = Object.assign({}, mockEnv, {
         npm_config_registry: "https://my-secure-registry/npm",
       });
 
-      const bootstrapCommand = new BootstrapCommand([], {});
-
       bootstrapCommand.runValidations();
       bootstrapCommand.runPreparations();
 

test/NpmUtilities.js

@@ -21,4 +21,33 @@ describe("NpmUtilities", () => {
       });
     });
   });
+
+  describe(".getExecOpts()", () => {
+    const originalEnv = Object.assign({}, process.env);
+    const mockEnv = {
+      mock_value: 1,
+      NODE_ENV: "lerna-test",
+    };
+
+    afterEach(() => {
+      process.env = originalEnv;
+    });
+
+    it("should handle environment variables properly", () => {
+      process.env = mockEnv;
+      const want = {
+        cwd: "test_dir",
+        env: Object.assign({}, mockEnv, {
+          npm_config_registry: "https://my-secure-registry/npm"
+        })
+      };
+      assert.deepEqual(NpmUtilities.getExecOpts("test_dir", "https://my-secure-registry/npm"), want);
+    });
+
+    it("should handle missing environment variables", () => {
+      process.env = mockEnv;
+      const want = {cwd: "test_dir"};
+      assert.deepEqual(NpmUtilities.getExecOpts("test_dir"), want);
+    });
+  });
 });