Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli compat check #705

Merged
merged 2 commits into from Mar 21, 2017
Merged

Conversation

evocateur
Copy link
Member

@evocateur evocateur commented Mar 21, 2017

Description

We should always allow semver-compatible CLI versions to operate on a given lerna monorepo, even pre-releases.

Currently, this will fail:

$ npm i -g lerna@canary
$ npm i -D lerna@canary
$ lerna init
$ lerna diff
# ^ fails due to validation error

Motivation and Context

The canary releases I've been doing recently were pointed out as failing with the latest changes from #694. Turns out I reversed the order of arguments to semver.satisfies() in that PR, and inadvertently conflated --exact dependency versioning with CLI version validation.

This fixes #702.

How Has This Been Tested?

Improved the quality and coverage of the existing InitCommand and Repository tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evocateur evocateur added this to the v2.0.0 milestone Mar 21, 2017
@evocateur evocateur merged commit 203f7eb into lerna:master Mar 21, 2017
@evocateur evocateur deleted the fix-cli-compat-check branch March 21, 2017 21:23
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use the canary release?
1 participant