Do not reject detached HEAD when publishing a canary release #711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To facilitate
--canary
publishes in CI, we shouldn't breaklerna publish
when it detects a detachedHEAD
when canary is enabled. We also need to avoid callinggit symbolic-ref
because it breaks in detachedHEAD
situations (which is going to be the case for a vast majority of CI environments). I renamed theGitUtilities
methodisDetachedHead()
to better express its intent.I've also clarified some of the internal flag parsing, creating a new
gitEnabled
instance property that better describes the intent behind!(this.flags.canary || this.flags.skipGit)
. I was able to simplify some of the conditionals as a result.This fixes #699
How Has This Been Tested?
I reordered the appropriate
ChildProcessUtilities.execSync
stubs, and added a new test for a complicated set of configuration to improve coverage.Types of changes
Checklist: