Fix durable option resolution #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 13, 2017 11:54
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A funny thing happened on the way to the forum...
Well, turns out I broke "durable" option config yesterday, so I decided to pull off the bandaid that's been itching me for weeks (the
Command#getOptions()API) and convert it into a lazy getter with lodash_.defaults()instead ofObject.assign().I've also made edits and tweaks to the
yargsoptions.Motivation and Context
Restoring durable config patterns, with some optimization thrown in.
How Has This Been Tested?
Local hoisted bootstraps and other operations, as well as more integration tests.
Types of changes
Checklist: