Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve internal CLI calls with Windows-safe pattern #771

Merged
merged 3 commits into from
Apr 18, 2017

Conversation

evocateur
Copy link
Member

@evocateur evocateur commented Apr 18, 2017

To protect Windows from itself, use explicit node path/to/cli.js [..args] call style.

Motivation and Context

The require.resolve() calls were removed in #759, not realizing yarn was going to rain on our parade very shortly. This PR builds on #770, which provides some optimizations to the rimraf calls independent of the local resolution issue.

#708 is fixed by this because we're not letting Windows Script Host get involved at all, instead calling the resolved CLI in the node path/to/cli.js [..args] pattern (which is implicitly what a shebang does, anyway).

How Has This Been Tested?

Local testing, because yet again I am foiled by unstable test snapshots (lerna publish --conventional-commits almost all the way there, except for the timestamps in the changelog output and actual commit history, etc). Le sigh.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

To protect Windows from itself, use explicit 'node <execFile>' call style.

Refs lerna#759
Fixes lerna#708
…n test

Skipped for now until the snapshot can be stabilized with actual history.
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant