Add --parallel flag to lerna run
#796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evocateur
commented
May 1, 2017
| describe: "Stream output with lines prefixed by package." | ||
| } | ||
| describe: "Stream output with lines prefixed by package.", | ||
| type: "boolean", |
There was a problem hiding this comment.
Discovered during the writing of new integration tests, without this explicit type one could cause a mangling of the arguments passed in by innocently re-ordering them. Obviously not very ideal.
|
Argh, I'm getting bitten by this line on Windows. 😡 |
This allows simpler invocation of `watch` scripts, with the caveat that
concurrency and topological sorting are _completely_ ignored.
This is generally the intention when calling `lerna run watch` and other
similar script targets, hence the additional flag.
# the following commands are equivalent
lerna run watch --concurrency=1000 --stream
lerna run watch --parallel
Package filtering (`--scope` and `--ignore`) is still available when this
new flag is being used, and it is advised to narrow the scope of parallel
execution when you have more than a dozen packages or so (YMMV).
9 tasks
|
Awesome, exactly what I'm looking for! Would it be possible to release this change @evocateur ? :) |
|
My goal is to release 2.0.0 this week.
… On May 14, 2017, at 02:20, Aeneas ***@***.***> wrote:
Awesome, exactly what I'm looking for! Would it be possible to release this change @evocateur ? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a new flag,
--parallel, to facilitate easier and less error-prone spawning of long-running watchers from npm scripts (e.g.,lerna run watch).Motivation and Context
This allows simpler invocation of
watchscripts, with the caveat that concurrency and topological sorting are completely ignored. This is generally the intention when callinglerna run watchand other similar script targets, hence the additional flag.# the following commands are equivalent $ lerna run watch --concurrency=1000 --stream $ lerna run watch --parallelPackage filtering (
--scopeand--ignore) is still available when this new flag is being used, and it is advised to narrow the scope of parallel execution when you have more than a dozen packages or so (YMMV).How Has This Been Tested?
local monorepo dev and copious unit and integration tests.
Types of changes
Checklist: