Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GPG signing of git tags #815

Merged
merged 1 commit into from May 19, 2017
Merged

Support GPG signing of git tags #815

merged 1 commit into from May 19, 2017

Conversation

alethea
Copy link
Contributor

@alethea alethea commented May 13, 2017

This PR allows Lerna to work with a user's git config to allow signing of tags.

Description

I removed the -a option from the invocation of git tag. Since we're invoking git tag with -m, this will have no effect on the generated tag unless a user has the tag.forceSignAnnotated option enabled in their git config.

Motivation and Context

This is the easy solution to #814

How Has This Been Tested?

All existing tests pass, both with and without tag.forceSignAnnotated enabled in my git config.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alethea!

@evocateur evocateur merged commit 56568d3 into lerna:master May 19, 2017
treshugart pushed a commit to treshugart/lerna that referenced this pull request May 24, 2017
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants