Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Prettier legacy options warning #236

Closed
pheeria opened this issue Jan 2, 2020 · 1 comment · Fixed by #239
Closed

Fix Prettier legacy options warning #236

pheeria opened this issue Jan 2, 2020 · 1 comment · Fixed by #239
Assignees
@danielstreif
Labels
dependencies Pull requests that update a dependency file
Projects
Roadmap to v1.1

Comments

@pheeria
Copy link
Member

pheeria commented Jan 2, 2020

More here
@pheeria pheeria created this issue from a note in Roadmap to v1.1 (To do) Jan 2, 2020
@pheeria pheeria added the dependencies Pull requests that update a dependency file label Jan 2, 2020
@danielstreif
Copy link
Collaborator

@pheeria @jarjan the warning is created by these deprecated settings in settings.json as far as I understand

"prettier.eslintIntegration": true,
"prettier.stylelintIntegration": true

https://github.com/prettier/prettier-vscode#linter-integration

Do we actually need these settings? As far as I see it we are using eslint and stylelint anyway.

@danielstreif danielstreif self-assigned this Jan 3, 2020
@danielstreif danielstreif mentioned this issue Jan 3, 2020
Merged
@danielstreif danielstreif moved this from To do to Review in Roadmap to v1.1 Jan 3, 2020
Roadmap to v1.1 automation moved this from Review to Done Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielstreif danielstreif

Labels
dependencies Pull requests that update a dependency file
Projects
Roadmap to v1.1
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated prettier settings Lernwerkstatt/site
2 participants
@pheeria @danielstreif