This repository has been archived by the owner on Jun 18, 2019. It is now read-only.

Upgrading Library #5

Merged

ravanscafi merged 17 commits into master from develop

Sep 4, 2017

Contributor

ravanscafi commented Aug 30, 2017 •

edited by gmsantos

Loading


          Upgrading composer autoloading and dependencies

424d10f

ravanscafi self-assigned this

leroy-merlin-br deleted a comment from coveralls


          Fix namespace for JsonFormatterTest

4fb2cb9

leroy-merlin-br deleted a comment from coveralls


          Update README

24ed314

gmsantos reviewed

View reviewed changes

.travis.yml Outdated

               before_script:
                 - curl -s http://getcomposer.org/installer | php
-                - php composer.phar install --dev
+                - php composer.phar install

Contributor

gmsantos Aug 30, 2017

travis already include composer

composer.json Outdated

    
                  "description": "A consumer for axado API.",

                  "keywords": ["axado","laravel","shipping", "brazil", "laravel","illuminate"],

                  "description": "A consumer for Axado API.",

                  "keywords": ["axado","laravel","shipping", "brazil", "laravel","cep","quotation","frete","brasil"],

Contributor

gmsantos Aug 30, 2017

why "brasil" and "brazil" ?

Contributor Author

ravanscafi Aug 30, 2017

whispers: blackhat seo

Contributor

gmsantos Sep 4, 2017

Remove spaces, or add in all?
"keywords": ["axado","laravel","shipping","brazil","cep","quotation","frete","brasil"],

composer.json Outdated

    
                      "phpunit/phpunit": "~4.2",

                      "mockery/mockery": "dev-master",

                      "mockery/mockery": "^0.9",

                      "phpunit/phpunit": "^5.7",

Contributor

gmsantos Aug 30, 2017

Any reason to not use phpunit 6 ?

tests/TestCase.php Outdated

+              {
+                  /**
+                   * {@inheritdoc}
+                   */
                   public function tearDown()

Contributor

gmsantos Aug 30, 2017

protected function tearDown() We dont need to a wide to public here.

leroy-merlin-br deleted a comment from coveralls


          Changes based on review

678cfbb

leroy-merlin-br deleted a comment from coveralls

ravanscafi added 2 commits

August 30, 2017 17:44


          Improving style and tests


          Drop deprecated request action and bump coverage

516d961

leroy-merlin-br deleted a comment from coveralls

leroy-merlin-br deleted a comment from coveralls

ravanscafi added 4 commits

August 31, 2017 09:10


          Add gitattributes file

6296f22


          Update dev autoload to use PSR4 for tests


          Drop unused quotation code

359f098


          Improve error reporting and drop unused info

062d410

coveralls commented Aug 31, 2017 •

edited

Loading

Coverage increased (+0.6%) to 100.0% when pulling 062d410 on develop into 578ef0b on master.

leroy-merlin-br deleted a comment from coveralls

ravanscafi changed the title ~~WIP: Upgrading Library~~ Upgrading Library

ravanscafi requested review from diegofelix, djonasm, vitorbari and gmsantos

September 4, 2017 16:50

gmsantos previously approved these changes

View reviewed changes

Contributor

gmsantos left a comment

laravel is duplicated after all

composer.json Outdated

    
                  "description": "A consumer for axado API.",

                  "keywords": ["axado","laravel","shipping", "brazil", "laravel","illuminate"],

                  "description": "A consumer for Axado API.",

                  "keywords": ["axado","laravel","shipping", "brazil", "laravel","cep","quotation","frete","brasil"],

Contributor

gmsantos Sep 4, 2017

Remove spaces, or add in all?
"keywords": ["axado","laravel","shipping","brazil","cep","quotation","frete","brasil"],

gmsantos and others added 3 commits

September 4, 2017 13:59


          Create LICENSE

d3dc073


          Create CODE_OF_CONDUCT.md

6ea8659


          Apply fixes from StyleCI

cb6b216

ravanscafi dismissed gmsantos’s stale review via

cb6b216

September 4, 2017 17:06

coveralls commented Sep 4, 2017 •

edited

Loading

Coverage decreased (-42.5%) to 56.897% when pulling cb6b216 on develop into 578ef0b on master.

ravanscafi added 3 commits

September 4, 2017 14:09


          Add StyleCI badge to readme

c95e22b


          Merge pull request #7 from leroy-merlin-br/add-code-of-conduct-1

1e6d2b0

Create CODE_OF_CONDUCT.md


          Merge pull request #6 from leroy-merlin-br/add-license-1

dc2171d

Create LICENSE

coveralls commented Sep 4, 2017 •

edited

Loading

Coverage decreased (-42.5%) to 56.897% when pulling 1e6d2b0 on develop into 578ef0b on master.

coveralls commented Sep 4, 2017 •

edited

Loading

Coverage decreased (-42.5%) to 56.897% when pulling dc2171d on develop into 578ef0b on master.

Contributor Author

ravanscafi commented Sep 4, 2017

Go home @coveralls, you are drunk

coveralls commented Sep 4, 2017 •

edited

Loading

Coverage decreased (-42.5%) to 56.897% when pulling dc2171d on develop into 578ef0b on master.

vitorbari reviewed

View reviewed changes

src/Quotation.php Outdated

+              class Quotation
+              {
+                  /**
+                   * Fields with be parsed after the response is returned.

vitorbari Sep 4, 2017

to be parsed?


          Changes based on review

49f4049

coveralls commented Sep 4, 2017 •

edited

Loading

Coverage decreased (-42.5%) to 56.897% when pulling 49f4049 on develop into 578ef0b on master.

leandrogrillo approved these changes

View reviewed changes

vitorbari approved these changes

View reviewed changes

vitorbari left a comment

Antes tarde do que nunca

ravanscafi merged commit 5868172 into master

ravanscafi deleted the develop branch

September 4, 2017 17:48

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

leandrogrillo leandrogrillo approved these changes

vitorbari vitorbari approved these changes

gmsantos gmsantos left review comments

diegofelix Awaiting requested review from diegofelix

djonasm Awaiting requested review from djonasm