Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed Queue Job Implementation #107

Merged
merged 12 commits into from
Sep 5, 2017
Merged

Failed Queue Job Implementation #107

merged 12 commits into from
Sep 5, 2017

Conversation

gmsantos
Copy link
Contributor

@gmsantos gmsantos commented Sep 4, 2017

No description provided.

@gmsantos gmsantos added this to the v2.0.0 milestone Sep 4, 2017
@gmsantos gmsantos self-assigned this Sep 4, 2017
@coveralls
Copy link

coveralls commented Sep 4, 2017 •
edited

Coverage Status

Coverage decreased (-3.2%) to 96.809% when pulling 03b709e on queue-failed into 4000397 on master.

@coveralls
Copy link

coveralls commented Sep 4, 2017 •
edited

Coverage Status

Coverage decreased (-3.2%) to 96.809% when pulling 368ca6c on queue-failed into 282033a on master.

@coveralls
Copy link

coveralls commented Sep 4, 2017 •
edited

Coverage Status

Coverage decreased (-3.2%) to 96.809% when pulling 368ca6c on queue-failed into 282033a on master.

@coveralls
Copy link

coveralls commented Sep 4, 2017 •
edited

Coverage Status

Coverage decreased (-3.2%) to 96.809% when pulling 8fc21d0 on queue-failed into 282033a on master.

vitorbari
vitorbari approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@vitorbari vitorbari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work mate!

src/MongolidServiceProvider.php
@@ -33,6 +34,8 @@ public function register()
public function boot()
{
$this->extendsAuthManager();

$this->replaceQueueFailer();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we make it optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't :)

@gmsantos gmsantos merged commit b72ee05 into master Sep 5, 2017
@gmsantos gmsantos deleted the queue-failed branch September 5, 2017 12:27
@gmsantos
Copy link
Contributor Author

gmsantos commented Feb 8, 2018 •
edited

close #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorbari vitorbari vitorbari approved these changes

@ravanscafi ravanscafi Awaiting requested review from ravanscafi

Assignees

@gmsantos gmsantos

Labels
Improvement
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmsantos @coveralls @vitorbari