Migrations #119
Merged
Migrations #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ravanscafi
commented
Oct 1, 2018
•
ravanscafi
commented
- Working migrations
- License
- Improve tests/coverage
- Documentation? (should be on mongolid)
- Hijack Laravel's migration commands?
added 8 commits
September 28, 2018 14:00
The license will be updated later :)
gmsantos
reviewed
Oct 1, 2018
| 'command.mongolid-migrate.refresh', | ||
| 'command.mongolid-migrate.reset', | ||
| 'command.mongolid-migrate.rollback', | ||
| 'command.mongolid-migrate.status', |
There was a problem hiding this comment.
we really need to create commands to mongolid?
With queue:failed was possible to overwrite the Laravel persistence layer only and reuse the default commands.
| use Illuminate\Console\ConfirmableTrait; | ||
| use Mongolid\Connection\Pool; | ||
| use Symfony\Component\Console\Input\InputOption; | ||
|
|
There was a problem hiding this comment.
Should we put a comment above the class to describe the command functionality?
There was a problem hiding this comment.
I guess that it would be the same as the $description attribute, so IMHO I see no need for it.
carusogabriel
approved these changes
Oct 3, 2018
diegofelix
approved these changes
Oct 3, 2018
This was referenced Oct 17, 2018
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.