Don't run update query if there is nothing to update

leroy-merlin-br · Dec 12, 2019 · 7d1cc25 · 7d1cc25
1 parent 485707b
commit 7d1cc25
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 1 deletion.
diff --git a/src/Mongolid/DataMapper/DataMapper.php b/src/Mongolid/DataMapper/DataMapper.php
@@ -175,7 +175,10 @@ public function update($entity, array $options = []): bool
         }
 
         $data = $this->parseToDocument($entity);
-        $updateData = $this->getUpdateData($entity, $data);
+
+        if (!$updateData = $this->getUpdateData($entity, $data)) {
+            return true;
+        }
 
         $queryResult = $this->getCollection()->updateOne(
             ['_id' => $data['_id']],

diff --git a/tests/Mongolid/DataMapper/DataMapperTest.php b/tests/Mongolid/DataMapper/DataMapperTest.php
@@ -371,6 +371,49 @@ public function testDifferentialUpdateShouldWork()
         $this->assertTrue($mapper->update($entity, $options));
     }
 
+    public function testDifferentialUpdateShouldReturnTrueIfThereIsNothingToUpdate()
+    {
+        // Arrange
+        $entity = m::mock(AttributesAccessInterface::class);
+        $connPool = m::mock(Pool::class);
+        $mapper = m::mock(DataMapper::class.'[parseToDocument,getCollection]', [$connPool]);
+
+        $options = ['writeConcern' => new WriteConcern(1)];
+
+        $entity->_id = 123;
+        $parsedObject = [
+            '_id' => 123,
+            'name' => 'Original Name',
+            'age' => 32,
+            'hobbies' => ['bike', 'skate'],
+            'nested' => [['field' => null]],
+            'data' => ['key' => '123'],
+        ];
+        $originalAttributes = $parsedObject;
+
+        // Act
+        $mapper->shouldAllowMockingProtectedMethods();
+
+        $mapper->shouldReceive('parseToDocument')
+            ->once()
+            ->with($entity)
+            ->andReturn($parsedObject);
+
+        $mapper->shouldReceive('getCollection')
+            ->never();
+
+        $entity->shouldReceive('originalAttributes')
+            ->once()
+            ->with()
+            ->andReturn($originalAttributes);
+
+        $this->expectEventToBeFired('updating', $entity, true);
+        $this->expectEventNotToBeFired('updated', $entity);
+
+        // Assert
+        $this->assertTrue($mapper->update($entity, $options));
+    }
+
     /**
      * @dataProvider getWriteConcernVariations
      */