Drop support for using plain objects as attributes due to the heavy c…

…ost and low benefit
leroy-merlin-br · Feb 1, 2019 · b8febac · b8febac
1 parent 7ac32b1
commit b8febac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/src/Model/HasAttributesTrait.php b/src/Model/HasAttributesTrait.php
@@ -1,7 +1,6 @@
 <?php
 namespace Mongolid\Model;
 
-use Exception;
 use Illuminate\Support\Str;
 use Mongolid\Container\Container;
 use stdClass;
@@ -189,11 +188,7 @@ public function setDocumentAttribute(string $key, $value)
      */
     public function syncOriginalDocumentAttributes()
     {
-        try {
-            $this->originalAttributes = unserialize(serialize($this->getDocumentAttributes()));
-        } catch (Exception $e) {
-            $this->originalAttributes = $this->getDocumentAttributes();
-        }
+        $this->originalAttributes = $this->getDocumentAttributes();
     }
 
     /**

diff --git a/tests/Integration/PersistedDataTest.php b/tests/Integration/PersistedDataTest.php
@@ -62,8 +62,8 @@ public function testSaveUpdatingData()
         $user->preferences = [];
         $user->friends = ['Mary'];
         $user->address = '123 Blue Street';
-        $user->skills->HTML = ['percentage' => '89%', 'version' => 'HTML5'];
-        $user->skills->PHP['version'] = '7.1';
+        $user->skills['HTML'] = ['percentage' => '89%', 'version' => 'HTML5'];
+        $user->skills['PHP']['version'] = '7.1';
 
         $expected = [
             '_id' => (string) $user->_id,
@@ -104,8 +104,8 @@ public function testUpdateData()
         $user->preferences = [];
         $user->friends = ['Mary'];
         $user->address = '123 Blue Street';
-        $user->skills->HTML = ['percentage' => '89%', 'version' => 'HTML5'];
-        $user->skills->PHP['version'] = '7.1';
+        $user->skills['HTML'] = ['percentage' => '89%', 'version' => 'HTML5'];
+        $user->skills['PHP']['version'] = '7.1';
 
         $expected = [
             '_id' => (string) $user->_id,
@@ -146,7 +146,7 @@ private function getUser(bool $save = false): ReferencedUser
         ];
         $user->friends = [];
         $user->address = null;
-        $user->skills = (object) [
+        $user->skills = [
             'PHP' => ['percentage' => '100%', 'version' => '7.0'],
             'JavaScript' => ['percentage' => '80%', 'version' => 'ES6'],
             'CSS' => ['percentage' => '45%', 'version' => 'CSS3'],